[SharedUX][Bugfix] Solution nav with no data page #144280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
commented
Oct 31, 2022
| @@ -53,11 +51,11 @@ export const withSolutionNav = <P extends TemplateProps>(WrappedComponent: Compo | |||
| isMediumBreakpoint || (canBeCollapsed && isLargerBreakpoint && !isSideNavOpenOnDesktop); | |||
| const withSolutionNavStyles = WithSolutionNavStyles(euiTheme); | |||
| const sideBarClasses = classNames( | |||
| 'kbnStickyMenu', | |||
There was a problem hiding this comment.
This is no longer needed as sticky is now set through page_template_inner: https://github.com/elastic/kibana/blob/main/packages/shared-ux/page/kibana_template/impl/src/page_template_inner.tsx#L74
|
@elasticmachine merge upstream |
rshen91
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
These changes look great! Thanks for adding the context in the PR #143114 (comment)
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
KOTungseth
added
the
Feature:Observability Overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR mitigates: #143114
The problem here was that solution nav was not rendered properly on the Observability page when
no datapage was displayed. The root cause is setting thecssprop on a<EuiPageTemplate.Sidebar />. See comment in the original issue for a detailed explanation. EUI has a fix for this, but it is not in KIbana yet.This PR replaces
emotion/reactwithemotion/cssto generate aclassNameinstead of thecssprop.Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list